Please remove event tracking from lua-template-rumtime (cocos2d-x 3.4rc0)

cocos2d / cocos2d-x

Cocos2d-x is a suite of open-source, cross-platform, game-development tools utilized by millions of developers across the globe. Its core has evolved to serve as the foundation for Cocos Creator 1.x & 2.x.

https://www.cocos.com/en/cocos2d-x

18.22k stars 7.05k forks source link

Please remove event tracking from lua-template-rumtime (cocos2d-x 3.4rc0) #9914

Closed ghost closed 9 years ago

ghost commented 9 years ago

Please remove event tracking from default Lua rumtime

it's slow down application startup
it's sending user's GUID to intenet :-(

It send event to google-analytics every-time application start /templates/lua-template-runtime/frameworks/runtime-src/Classes/AppDelegate.cpp

ghost commented 9 years ago

It's better to track the event from 'Cocos Code IDE'.
- Hash GUID before sending to internet.

dualface commented 9 years ago

because the Google Analysis request is async, so it's not slow down startup
we will hash GUID before sending to internet, thanks

ghost commented 9 years ago

Thank you for quick response. But my concern is Cocos2d-x + Lua runtime should not tracking .

It should not track from Cocos2d-x + Lua runtime, other developer don't known that the runtime send data to Google Analysis if they don't look in AppDelegate.cpp.
Other case is user (who play game) was tracked, too.

dualface commented 9 years ago

Yes, you are right. we will remove google analysis from template, keep it in pre-build simulator. We need known how many developers use simulator for development.

Thanks for your advices.

ghost commented 9 years ago

Changed in 3.4rc1 is looking good.

Tracking only in pre-build simulator
Manual build is not tracking (both debug, and release)

Thank you