improve handling of uppercased german Umlauts (Ä to Ae instead of AE)

cocur / slugify

Converts a string to a slug. Includes integrations for Symfony, Silex, Laravel, Zend Framework 2, Twig, Nette and Latte.

MIT License

2.89k stars 252 forks source link

improve handling of uppercased german Umlauts (Ä to Ae instead of AE) #315

Open thyseus opened 2 years ago

thyseus commented 2 years ago

Why?

It is much more common that a german word containing uppercased Umlauts will be transformed with a small second character:

Äpfel -> Aepfel Öl -> Oel

perhaps this is also the case in other languages. What are your opinions about this ?

JonathanMH commented 2 years ago

I agree this might be a common use case, but it might not be the intention of everyone using it. It could be a passable option or just be up to the user to capitalise their strings as they desire.