Closed MrMooky closed 1 year ago
Thank you so much for the PR. And sorry for the talking so long to merge it.
@florianeckerstorfer Thanks for adding this! I've just started supporting Korean for one of my clients and this has come in super helpful. How can I add this to my project as I see it's not in the release code yet :(
@dpDesignz Released a new version 4.4
@dpDesignz Released a new version 4.4
@florianeckerstorfer Thanks, I've updated to 4.4.0, but I'm still getting a ruleset 'korean' does not exist
error. Am I missing a step?
@dpDesignz It is not a default rule, you need to activate it
$slugify->activateRuleSet("korean");
@dpDesignz It is not a default rule, you need to activate it
$slugify->activateRuleSet("korean");
@florianeckerstorfer this is my code which I'm getting the error with
// Get SEO friendly URL
$url = new Slugify();
$url->activateRuleSet('korean');
$url = $url->slugify($string);
It's the $url->activateRuleSet('korean);
line that I'm getting the ruleset 'korean' does not exist
error on
I see Run php bin/generate-default.php
as step 3 for adding a language which I'm not sure has been done? I tried to download the repo to do this myself but I couldn't get it to download the entire repo, it would only download the release for some reason.
Hey @florianeckerstorfer, just following this up please? :) It's still not working for me and I'm not sure where to look to test this.
@dpDesignz Sorry, my bad I didn't generate the default ruleset. Should be fixed in v4.5.0
Building on a closed PR, I created a new one for Korean translation. I had one of my (Korean) customers quickly look over and got "There seems to be no problem with what you sent.".