search

cocur / slugify

Converts a string to a slug. Includes integrations for Symfony, Silex, Laravel, Zend Framework 2, Twig, Nette and Latte.
MIT License
2.89k stars 252 forks source link

fix: Add types to avoid PHP 8.2 deprecation warning #322

Closed antoniovj1 closed 1 year ago

antoniovj1 commented 1 year ago

Hi team,

I wanted to let you know about a deprecation warning I've been getting in all my projects since updating to PHP 8.2. The warning is related to using nullable types instead of strings.

Here's the link to the PHP 8.1 deprecation notice: link

To address this, I think we should improve the types used in the slugify method, but it would be a breaking change.

Another option is to check for null at the beginning of the method and return an empty string in that case. However, I'm not sure if this is the best solution.

Please share your thoughts on whether this approach is correct or if you have any other ideas.

Thanks.

antoniovj1 commented 1 year ago

Thanks!! @florianeckerstorfer