search

coda / packs-sdk

SDK for Coda Packs
https://coda.io/why-build-packs
MIT License
89 stars 25 forks source link

Update SDK to support sibling acls #3041

Closed drew-codaio closed 2 weeks ago

drew-codaio commented 3 weeks ago

Part of the work for sibling ACLs. Updating permissions to have a new delegated type.

patrick-codaio commented 3 weeks ago

cc @ekoleda-codaio

patrick-codaio commented 3 weeks ago

Another way I thought about doing this is that we could let a sync table schema have a permissionDelegationProperty which would need to be a reference to another table.

But I think that could live side-by-side with this, so no objection from me.

sam-codaio commented 3 weeks ago

Yeah we can't release this right away I think? Need to update coda to add support to recognize support for this and support backwards compatibility, then need to have a PR read to fast merge to update every pack that uses permissions? Unless we change the SDK to be backwards compatible.

Why not just make the SDK backwards compatible for now (Direct permissions can have no type there and we assume direct?)

drew-codaio commented 2 weeks ago

Yeah we can't release this right away I think? Need to update coda to add support to recognize support for this and support backwards compatibility, then need to have a PR read to fast merge to update every pack that uses permissions? Unless we change the SDK to be backwards compatible.

Why not just make the SDK backwards compatible for now (Direct permissions can have no type there and we assume direct?)

good point.

jonathan-codaio commented 2 weeks ago

Make sure to fast follow with coda or packs changes to incorporate these, the SDK is evolving fast and if changes break TS somebody else's SDK change could be stuck behind getting those fixed. I'll share this with the team as well.

drew-codaio commented 2 weeks ago

Make sure to fast follow with coda or packs changes to incorporate these, the SDK is evolving fast and if changes break TS somebody else's SDK change could be stuck behind getting those fixed. I'll share this with the team as well.

My bad still trying to figure out how this whole ecosystem works with the sdk. Will be mindful going forward. Sam and I are working on the fast follow rn.

jonathan-codaio commented 2 weeks ago

No need to apologize, there's lots of unwritten best practices to navigate, just spreading awareness.