codacy / codacy-coverage-reporter

Multi-language coverage reporter for Codacy
https://www.codacy.com
Other
135 stars 94 forks source link

When sending partial report let users know that a final signal is still required #227

Closed franciscodua closed 4 years ago

franciscodua commented 4 years ago

Currently, users that want to send more than one report, or that use the partial flag see the following message at the end: All coverage data uploaded.. Which might indicate the process of sending coverage is complete. It is not!

Suggestion: When the user still needs to send the final signal to Codacy, we should print All coverage data uploaded. To complete the reporting process, call the coverage-reporter with a final flag. ./coverage-reporter final

Acceptance criteria:

prcr commented 4 years ago

Is there still time for me to suggest a small tweak to the copy?

All coverage data uploaded. To complete the reporting process, call coverage-reporter with the final flag: ./coverage-reporter final

franciscodua commented 4 years ago

Is there still time for me to suggest a small tweak to the copy?

All coverage data uploaded. To complete the reporting process, call coverage-reporter with the final flag: ./coverage-reporter final

Sure, the proposed message is currently

To complete the reporting process, call the coverage-reporter with a final flag.
Check https://github.com/codacy/codacy-coverage-reporter#multiple-coverage-reports-for-the-same-language for more information.

What do you think?

You can check the PR in #228

prcribeiro commented 4 years ago

Thanks, I left my suggestion on the pull request. :+1: