search

codacy / codacy-coverage-reporter

Multi-language coverage reporter for Codacy
https://www.codacy.com
Other
134 stars 94 forks source link

[CY-2851] Missing support for sendFinalWithProjectName #254

Closed willhausman closed 3 years ago

willhausman commented 4 years ago

Following the steps mentioned in documentation for multiple reports, the last thing to do is send a final notification. When also managing multiple projects with an API Token, the api supports sending the final notification. The coverage reporter does not.

https://github.com/codacy/codacy-api-scala/blob/dbea2e290bf58229851c9c2e1418c53070fbff3d/src/main/scala/com/codacy/api/service/CoverageServices.scala#L76

https://github.com/codacy/codacy-coverage-reporter/blob/bdda1928207e67e08f7da8092d2203b3b9effe3c/src/main/scala/com/codacy/rules/ReportRules.scala#L273-L275

github-actions[bot] commented 4 years ago

Internal ticket created : CY-2851

petero-dk commented 3 years ago

Additionally the circle-orb does not support this use case either as it only works with project api

petero-dk commented 3 years ago

Once this is supported in the binary, the orb can be updated to support it by using this pr #255

machadoit commented 3 years ago

Hi @petero-dk unfortunately we are checking some details internally regarding the API token usage, since it seems that it is only working for legacy repositories.

But either way, can you share your use case a bit better? Our use case for the partial coverage is to send multiple reports for the same repository, not to aggregate the coverage among different ones.

machadoit commented 3 years ago

@willhausman we are closing this and @petero-dk contribution. Thanks for raising this up, but we are going to close this issue for now, as we don't have any ETA on when/how we want to tackle this issue