search

codacy / git-version

Git versioning used in Codacy
Apache License 2.0
134 stars 44 forks source link

fix: Add log-paths to docker run parameters #65

Open oleksandr-ivanov-ah opened 2 years ago

oleksandr-ivanov-ah commented 2 years ago

I have added missed --log-paths parameter to the /bin/git-version execution

oleksandr-ivanov-ah commented 2 years ago

@h314to Hello. Could you please review this small hotfix

oleksandr-ivanov-ah commented 1 year ago

It is very difficult to contribute to your repo if you reviewing 2 line changes for more then 2 month

oleksandr-ivanov-ah commented 1 year ago

@h314to can you please have a look at the PR

h314to commented 1 year ago

Build fails

oleksandr-ivanov-ah commented 1 year ago

@h314to the pipelines fails with error: E: Repository 'https://cli-assets.heroku.com/apt ./ InRelease' changed its 'Origin' value from 'Heroku' to 'Jeff Dickey @jdxcode' This error dosn't related to my pr changes. I just added 1 line in acrion yaml file: --log-paths="${{ inputs.log-paths }}"

There couple of opened issues that can't solved by my pr ( [CY-6648] log-paths is unused and [TS-192] Monorepo prefix does not pick up last version ).

From the consumer perspective codacy doesn't support it's github actions, I already switched to release-please from google.