codahale / shamir

A Java implementation of Shamir's Secret Sharing algorithm over GF(256).
Apache License 2.0
207 stars 84 forks source link

Expanded (multiple) secret sharing #5

Closed ba1ciu closed 6 years ago

ba1ciu commented 6 years ago

I had to share a secret between users and system, so that system's part is necessary to recover a secret, regardless of how many user's parts will be joined and i came up with an idea of sharing a secret multiple times. I described my method in expanded_readme. Please let me know what do you think about it. Cheers!

codahale commented 6 years ago

Hi @ba1ciu! Congrats on your first pull request and thank you for the contribution. This is a really interesting design and it seems generalizable to a tree of arbitrary fanout.

Because this is such a broad pattern, though, I don’t think it’s a good fit for this library. I’d love to add a writeup of this technique in the readme, however, for people with similar requirements. Would you mind if I did that and gave you attribution?

ba1ciu commented 6 years ago

Thanks for your reply @codahale! I wanted to share my idea, because I think a lot of people might run into a similar problem and of course I would be really happy if you mention about this technique in the readme.

codahale commented 6 years ago

I’ve added a writeup to the readme, along with a sample implementation. Please let me know if you think I’ve missed anything. Again, thank you for your contribution! I’m sure this will be helpful to others. :)