search

codahale / sneaker

A tool for securely storing secrets on S3 using Amazon KMS.
Other
800 stars 34 forks source link

Fix #16: Pass in session objects when creating s3 and kms #17

Closed jietang closed 8 years ago

jietang commented 8 years ago

So word of warning, I don't write much go code, but I came across the same issue as https://github.com/codahale/sneaker/issues/16 and https://github.com/codahale/sneaker/pull/17/commits/7745c905d772977d1fb3b08244f22334973f9955 fixed it. Maybe take this as another vote for a fix.

dstnbrkr commented 8 years ago

Ran into the same issue when updating to v1.2.7 of the AWS Go library and this seems to fix it.

codahale commented 8 years ago

I’d merge this, but the tests are failing.

codahale commented 8 years ago

Fixed by #20.