search

codahale / sneaker

A tool for securely storing secrets on S3 using Amazon KMS.
Other
801 stars 34 forks source link

Switch from godep to govendor to fix CI #22

Closed dstnbrkr closed 8 years ago

dstnbrkr commented 8 years ago

Currently CI won't pass for the master branch (the last run passed under go 1.4, but the same run w/ go 1.7 fails: https://github.com/codahale/sneaker/pull/21)

Godep/_workspaces is deprecated, but we can use the vendor folder to store dependencies. There a lots of tools for managing vendor, I picked govendor but any other tool (glide, etc) will do as well.

dstnbrkr commented 8 years ago

brb - the deps in vendor are submodules but should've been real files

dstnbrkr commented 8 years ago

OK, at long last tests finally pass - this will resolve test failures in https://github.com/codahale/sneaker/pull/20 (which I'll need to rebase).

codahale commented 8 years ago

Awesome! Thanks so much!