codalab / codabench

Codabench is a flexible, easy-to-use and reproducible benchmarking platform. Check our paper at Patterns Cell Press https://hubs.li/Q01fwRWB0
Apache License 2.0
60 stars 26 forks source link

save comp to persist logo_icon #1447

Closed bbearce closed 1 month ago

bbearce commented 1 month ago

@ mention of reviewers

@ihsaan-ullah @Didayolo

A brief description of the purpose of the changes contained in this PR.

Upon comp logo upload in competition editor, the logo_icon minio path isn't being updated (even though logo icon was being created). This change makes a specific call to save the competition post making a logo_icon.

Basically the competition.save method is saving everything about a competition when you save from the ui, except the new small icon it created. So even though we do an initial save with super().save(*args, **kwargs), we now resave after making the small logo to ensure the new path is reflected in the database.

Issues this PR resolves

A checklist for hand testing

Any relevant files for testing

Checklist