codalab / codabench

Codabench is a flexible, easy-to-use and reproducible benchmarking platform. Check our paper at Patterns Cell Press https://hubs.li/Q01fwRWB0

Apache License 2.0

76 stars 28 forks source link

programs and datasets bug fixed #1528

Closed ihsaan-ullah closed 4 months ago

ihsaan-ullah commented 4 months ago

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Files were not shown for competitions with tasks without ingestion and input data. Now that is fixed

NOTE

The logic of datasets and files are on the frontend here: https://github.com/codalab/codabench/blob/1d2eda724650affb1f1fe965402beeed0b014218/src/static/riot/competitions/detail/_tabs.tag#L238 This logic should be moved to the backend (In my opinion)

Issues this PR resolves

1516
1236

A checklist for hand testing

[x] enable/disable programs and datasets and test that a participant can see them in files tab

Checklist

[x] Code review by me
[x] Hand tested by me
[x] I'm proud of my work
[x] Code review by reviewer
[x] Hand tested by reviewer
[x] CircleCi tests are passing
[x] Ready to merge

ihsaan-ullah commented 4 months ago

@Didayolo this is ready to be merged. I have resolved the comment on the empty list