Fix LinkNode paths for getTypeManifestVisitor

codama-idl / codama

Generate clients, CLIs, documentation and more from your Solana programs

MIT License

103 stars 20 forks source link

Fix LinkNode paths for getTypeManifestVisitor #284

Closed lorisleiva closed 4 weeks ago

lorisleiva commented 4 weeks ago

This PR fixes an issue in the JavaScript getTypeManifestVisitors where complex link node paths would be incorrectly resolved due to the fact that the NodeStack would follow in invalid path in the tree. The new methods to save and restore NodePaths inside the NodeStack help us fix this.

changeset-bot[bot] commented 4 weeks ago

🦋 Changeset detected

Latest commit: 452424e7094b03efb2660bcb885d9e40d4cb5c09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | ------------------------ | ----- | | @codama/renderers-js-umi | Minor | | @codama/renderers-js | Minor | | @codama/renderers | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lorisleiva commented 4 weeks ago

#287
#286
#285
#284 👈
#283
#282
#281
#280
#275
#274
#270
#269
#266
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on Graphite

lorisleiva commented 4 weeks ago

Merge activity

Nov 4, 8:46 AM EST: A user started a stack merge that includes this pull request via Graphite.
Nov 4, 9:15 AM EST: Graphite rebased this pull request as part of a merge.
Nov 4, 9:16 AM EST: A user merged this pull request with Graphite.