search

codappix / search_core

TYPO3 CMS 8.x Extension with basic Integration of Elasticsearch
https://search-core.readthedocs.io/en/latest/
12 stars 9 forks source link

Make it work with Algolia #109

Closed martinhummer closed 6 years ago

martinhummer commented 6 years ago

I propose a small change by adding a return statement to the AbstractIndexer.php file.

Algolia is returning some request information after calling f.ex. addDocument() on the index and I need to pass that on to my custom Algolia Connection.

An example is implemented here: https://github.com/martinhummer/search_algolia/blob/master/Tests/Functional/Connection/Algolia/IndexTcaTableTest.php

DanielSiepmann commented 6 years ago

We can change that, but accordingly to your description I do not see any purpose. If you need the return values inside of your connection, then everything is available yet. The indexer is calling the Connection, therefore just implement everything inside of your Connection.

We can also discuss that via phone.

martinhummer commented 6 years ago

Thanks Daniel, I'm out of office today, but will come back to you on monday.

Am 08.02.2018 um 18:08 schrieb Daniel Siepmann notifications@github.com:

We can change that, but accordingly to your description I do not see any purpose. If you need the return values inside of your connection, then everything is available yet. The indexer is calling the Connection, therefore just implement everything inside of your Connection.

We can also discuss that via phone.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.