search

codappix / search_core

TYPO3 CMS 8.x Extension with basic Integration of Elasticsearch
https://search-core.readthedocs.io/en/latest/
12 stars 9 forks source link

BUGFIX: Do not resolve inputDateTime as relation #150

Closed DanielSiepmann closed 6 years ago

DanielSiepmann commented 6 years ago

Add test which checks this behaviour. Exclude inputDateTime from relation resolving.

Resolves #147

martinhummer commented 6 years ago

I think the TCA Config is not correct. I made a new version of the test, which uses the TCA config for tt_content field 'starttime' in 8.7.12 LTS: https://github.com/martinhummer/search_core/blob/develop/Tests/Unit/Domain/Index/TcaIndexer/RelationResolverTest.php

This test will fail, because BackendUtility::getProcessedValueExtra returns a String like '06-04-18 10:36' and not a timestamp.

Do you think it would be possible to exclude inputDateTime fields completely from this processing and return the (int) timestamp as it is in the database.

DanielSiepmann commented 6 years ago

I can't see any difference of the TCA Configuration. Without the change to skip the renderType I'll receive an empty value for starttime in the test. With the change I'll receive the original value. Perhaps we can chat on that to make sure it works as expected?

DanielSiepmann commented 6 years ago

We will keep the test, but will not process this issue itself anymore. Instead, see the issue, we will resolve this by working on #149 .