search

codatio / codat-js

Javascript Client Library for Codat accounting data API
Apache License 2.0
4 stars 0 forks source link

Export CodatApiClient #8

Closed Hawk94 closed 7 years ago

Hawk94 commented 7 years ago

Export the CodatAPIClient explicitly allowing it to be used directly.

christopherdcunha commented 7 years ago

Instead of this PR, would you be able export CodatApiClient?

jasond-s commented 7 years ago

@Hawk94 I am inclined to agree with @christopherdcunha here. This is really a helper around interacting with the codat API and adding a proxy environment and subtly, but fundamentally, changing the meaning of the apiKey in the base class Api is not ideal. Exposing the actual class that does the work sounds ok though, and it's less code 😛 .

Hawk94 commented 7 years ago

@jasond-s I agree - have amended this PR to export the CodatAPIClient, it would be great if you could review/merge 😄

jasond-s commented 7 years ago

Looks good. Thanks guys!

jasond-s commented 7 years ago

Will get that published ASAP.