search

codaxy / wkhtmltopdf

C# wrapper around excellent wkhtmltopdf console utility.
265 stars 92 forks source link

All-round polishments #16

Closed fean closed 7 years ago

fean commented 8 years ago

Also the tests are working now, it was a minor error. I assumed that only when PdfDocument.Url == null I had to use PdfDocument.Html. That has been fixed now.

May I suggest something: cloning my forked repo to test if it works. After you've reviewed the code you can then merge my pull request.

Merry Christmas! :santa:

fean commented 8 years ago

I added everything into unit tests, even though there is no precise way to check if the conversion was successful. This way it's somewhat easier to run within the visual studio environment.

Also in the future more specified tests can be written, to more accurately test the internals of the code.

Merry Christmas! :santa: