codbex / codbex-kronos

SAP HANA XS Classic and ABAP Compatibility Platform
https://codbex.com
Eclipse Public License 2.0
5 stars 3 forks source link

[IDE] XSK and Dirigible settings might interfere under the same domain #156

Open BorisNen opened 2 years ago

BorisNen commented 2 years ago

From xsk created by StanZGenchev: SAP/xsk#415

Describe the bug Currently, XSK and Dirigible share the same settings if running under the same domain. This can cause serious issues if the XSK and Dirigible versions mismatch.

Example scenario: XSK (built with Dirigible v5) and Dirigible v6 are used under the 'sap.com' domain for thing A and thing B, respectively. User X has to work with thing A and thing B, and uses the same PC to do so. Since XSK uses Dirigible v5 which has incompatible settings with Dirigible v6, there will most likely be visual glithes, usability bugs and/or pages not rendering correctly.

This is related to Dirigible issue #1071 - https://github.com/eclipse/dirigible/issues/1071

BorisNen commented 2 years ago

Such settings are stored in browser's Local Storage, for example

Proposal: Introduce new environment variable _(e.g. DIRIGIBLE_BRANDING_KEY)_ to the list of branding related environment variables, that will be used as prefix when storing settings in the Local Storage:

DIRIGIBLE_BRANDING_KEY=XXX