search

codbex / codbex-kronos

SAP HANA XS Classic and ABAP Compatibility Platform
https://codbex.com
Eclipse Public License 2.0
5 stars 3 forks source link

[ODATA] Some XSODATA entities return 500 error #570

Closed pkjanocha closed 1 month ago

pkjanocha commented 1 month ago

There is a problem with some oData services. When I try to get most of them, I get 500 error. Not sure if this is a cause, but the ones I checked are based on database views. Also the error claims that schema name is my database user - it may be fine, but I am not sure.

image image
iliyan-velichkov commented 1 month ago

Hi @pkjanocha,

It seems that some of the public synonyms are missing. That's why the OData returns the mentioned error. The code is trying to resolved the declared tables/views in the xsodata files in several places but they don't exist. https://github.com/codbex/codbex-kronos/blob/main/components/engine-xsodata/src/main/java/com/codbex/kronos/engine/xsodata/transformers/TableMetadataProvider.java#L83-L106

You can recreate all the required synonyms and the OData should be fine. Meanwhile, I will try to add an implementation which will resolve tables/views from different schemas. This way, synonyms will not be required.

pkjanocha commented 1 month ago

Hi! I'll try it, thanks!.

iliyan-velichkov commented 1 month ago

Hi @pkjanocha,

Did you test it?

pkjanocha commented 1 month ago

Hi Iliyan. I checked the database and some synonyms are definitely missing. However they are not generated automatically and I didn't try to recreate them manually yet as I'm quite busy with other things. I'll do that that week

iliyan-velichkov commented 1 month ago

Hi @pkjanocha,

I implemented the mentioned functionality which allows you to expose tables/views from different schema without the need of synonyms - https://github.com/codbex/codbex-kronos/pull/579 Please build your image with the latest kronos image and try again. Let me know if there are issues.

pkjanocha commented 1 month ago

Hi Iliyan,

Great news, because I've just started recreating missing synonyms manually. I'll let you know in a moment if it works

pkjanocha commented 1 month ago

FYI, the Odata seems to be working fine for now, at least the endpoints that were previously causing errors. I'll test more scenarios today to see if any issues still exists in the application.