search

codbex / codbex-kronos

SAP HANA XS Classic and ABAP Compatibility Platform
https://codbex.com
Eclipse Public License 2.0
5 stars 3 forks source link

[IDE] Debugger - XSJS files debugging is weird #78

Open Fluctuationqt opened 2 years ago

Fluctuationqt commented 2 years ago

From xsk created by ThuF: SAP/xsk#1181

Details about the issue could be found here: https://github.com/eclipse/dirigible/issues/1539

Inside XSK the experience is even worse, as there are 10+ modules (the whole XSJS API and its dependencies) that you have to go through in order to debug the following hello world code:

$.response.setBody("Hello World!");
Fluctuationqt commented 2 years ago

@vmutafov, @tdermendjiev is this issue closed by:

Fluctuationqt commented 2 years ago

This should be closed once we have a new release of the Dirigible.

Fluctuationqt commented 2 years ago

@vmutafov Okay, thanks for the update! Does it mean that we'll close this issue and open different one where we'll track the progress, or we'll keep this open until everything is fixed?

Fluctuationqt commented 2 years ago

@ThuF this is partially fixed. Although we have removed some unnecessary module loading related debug code, the issue is still observed as we treat XSK/Dirigible internal JS code as non-internal when loading it into the GraalJS. I have created a PoC about marking the xsjs APIs as internal but I'm still testing it in the XSK environment. So far it passes the Dirigible unit tests. I'll create issues for these improvements in the Dirigible and link them here.