SIM7000.cpp:280:1: error: no return statement in function returning non-void

coddingtonbear / arduino-async-modem

Asynchronously interact with your SIM7000 LTE modem

8 stars 3 forks source link

SIM7000.cpp:280:1: error: no return statement in function returning non-void #2

Open fr34kyn01535 opened 2 years ago

fr34kyn01535 commented 2 years ago

https://github.com/coddingtonbear/arduino-async-modem/blob/4ef85c1bd2800160e88b99846763c04b58a2641f/src/SIM7000.cpp#L279

This method should return void, if its not intended to return a boolean here...

coddingtonbear commented 2 years ago

Perhaps you could file a pull request…

fr34kyn01535 commented 2 years ago

There is plenty more compiler issues in arduino-async-duplex, i have disabled all warnings for now.. that fixes compilation issues atleast.

coddingtonbear commented 2 years ago

If you were just wanting to put a red mark on somebody's homework, you can totally feel like you've accomplished your goal. This is an open-source project, though: if you'd like to help improve the project rather than just comment on its flaws, please file a pull request.