Replace deprecated ugettext_lazy with gettext_lazy

coddingtonbear / django-measurement

Easily store, retrieve, and convert measurements of weight, volume, distance, area and more.

MIT License

145 stars 33 forks source link

Replace deprecated ugettext_lazy with gettext_lazy #108

Closed Ashlett closed 2 years ago

Ashlett commented 3 years ago

ugettext_lazy has been an alias for gettext_lazy since Django stopped supporting Python 2 in version 2.0 (see source).

Now it is also deprecated and produces a RemovedInDjango40Warning:

RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().

See e.g. this CI run.

This PR replaces ugettext_lazy with gettext_lazy.

Ashlett commented 3 years ago

@codingjoe friendly ping: can you approve the workflow, and then the PR if you see fit?

codingjoe commented 2 years ago

Hi @Ashlett,

Sorry, I somehow missed the notification here. There is a rewrite of this package in the works, that supports the latest version of python-measurements, but I don't have the time to finish it. Maybe you are interested coming on as a maintainer for this project? I heard only good things about you ;)

But for now, let's merge this!

Best Johannes