add support for more Measurements

coddingtonbear / python-myfitnesspal

Access your meal tracking data stored in MyFitnessPal programatically

MIT License

794 stars 136 forks source link

add support for more Measurements #111

Closed kb1900 closed 2 years ago

kb1900 commented 3 years ago

Fixes https://github.com/coddingtonbear/python-myfitnesspal/issues/110

DEFAULT_MEASURE_AND_UNIT KeyError: 'fiber', KeyError: ''potass.'

Please let me know if I am doing anything incorrectly - this is my first PR. thanks in advance @coddingtonbear . i hope to also make some contributions to your other repos soon.

cheers

coddingtonbear commented 3 years ago

Thanks for taking the time to post a PR! There're just a couple little changes above that I wonder if I could convince you into making before we merge this. Let me know if you need a hand with any of that, though!

Cheers!

kb1900 commented 3 years ago

Hey @coddingtonbear I believe I made both changes correctly if you could please re-review when you get the chance. Thanks once again for the feedback here!

Only uncertainty I have is that I was already using black for formatting and running the command on my code from command line or within sublime or vs code all resulted in the same changes. I must have some config issue (maybe my linter) somewhere I will figure out for the future!