coddingtonbear / python-myfitnesspal

Access your meal tracking data stored in MyFitnessPal programatically
MIT License
800 stars 138 forks source link

Extra white space in 'totals' and 'goals' #34

Closed agbrook closed 8 years ago

agbrook commented 8 years ago

There seems to have been a change on the myfitnesspal.com side that is adding \ncalories\n' to at least the goals and totals results. I was able to fix it locally by changing the following function in client.py:

def _get_full_name(self, raw_name): name = raw_name.lower().strip() if name not in self.ABBREVIATIONS: return name return self.ABBREVIATIONS[name]

I didn't want to go through creating a pull request for 8 characters, but thought it might be something that you could use.

coddingtonbear commented 8 years ago

Thanks for the bug report! I'm curious about why you're resisting posting a pull request for this -- it'd help lots of people, and it might be a few days before I get a chance to circle back and have a look at this. I promise -- it's easier than it sounds if you have already cloned the repo and made the changes!

agbrook commented 8 years ago

My reasoning is that I hadn’t already cloned the repo. I made the changes directly in site-packages/myfitnesspal. Mostly just laziness. I can go through the process though, if its going to be a little while for you. I haven’t nothing against it.

Andy Brook Sr. Systems Administrator | Center for Research Informatics | University of Chicago T: 773-834-0458 | http://cri.uchicago.edu

From: Adam Coddington notifications@github.com Reply-To: coddingtonbear/python-myfitnesspal reply@reply.github.com Date: Wednesday, June 22, 2016 at 1:29 PM To: coddingtonbear/python-myfitnesspal python-myfitnesspal@noreply.github.com Cc: Andy Brook abrook@bsd.uchicago.edu, Author author@noreply.github.com Subject: Re: [coddingtonbear/python-myfitnesspal] Extra white space in 'totals' and 'goals' (#34)

Thanks for the bug report! I'm curious about why you're resisting posting a pull request for this -- it'd help lots of people, and it might be a few days before I get a chance to circle back and have a look at this. I promise -- it's easier than it sounds if you have already cloned the repo and made the changes!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/coddingtonbear/python-myfitnesspal/issues/34#issuecomment-227835123, or mute the threadhttps://github.com/notifications/unsubscribe/AIeDQA8DFYILSgMVlbpML3CMnA1JUxRiks5qOX7wgaJpZM4I8Evy.


This e-mail is intended only for the use of the individual or entity to which it is addressed and may contain information that is privileged and confidential. If the reader of this e-mail message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is prohibited. If you have received this e-mail in error, please notify the sender and destroy all copies of the transmittal.

Thank you University of Chicago Medicine and Biological Sciences


coddingtonbear commented 8 years ago

Thanks for the PR, sir!