code-423n4 / 2021-04-basedloans-findings

0 stars 1 forks source link

now is still used #10

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

gpersoon

Vulnerability details

Impact

Most of the time block.timestamp is used, however in 1 location now is still used. The global variable now is deprecated in solidity 7: https://docs.soliditylang.org/en/v0.7.0/070-breaking-changes.html#changes-to-the-syntax

Proof of Concept

.\Governance\Blo.sol: require(now <= expiry, "Comp::delegateBySig: signature expired");

Tools Used

grep

Recommended Mitigation Steps

Replace now with block.timestamp

ghoul-sol commented 3 years ago

Added to backlog for later refactoring, thanks!