code-423n4 / 2021-04-basedloans-findings

0 stars 1 forks source link

[Info] functions 'getUnderlyingPriceView' and 'price' are too similar #29

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

paulius.eth

Vulnerability details

Impact

Not a bug, just FYI: function getUnderlyingPriceView is too similar to function price. I think it would be better to avoid code duplication by extracting common code and using it where necessary. Less code duplication makes it easier to maintain it and improves readability.

ghoul-sol commented 3 years ago

It's added to our backlog for refactoring, thanks!