code423n4 commented 3 years ago

Handle

gpersoon

Vulnerability details

Impact

Several function are defined to be public and others are external. Even with very similar functions the use of public and external differs. Making this the same everywhere (where possible) will make the code cleaner

Proof of Concept

LoanFactory.sol: function createLoan(..) external whenNotPaused returns (address) {

PoolFactory.sol: function createPool(..) public whenNotPaused returns (address) {

Tools Used

editor

Recommended Mitigation Steps

Use public and external in a consistent way

lucas-manuel commented 3 years ago

Will address this, informational issue, not bug.