code-423n4 / 2021-04-maple-findings

0 stars 0 forks source link

Multiple pause mechanisms (#3) #21

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

gpersoon

Vulnerability details

This is an addition to the previous issue: Multiple pause mechanisms

Impact

There is a third pause mechanism in MplRewards.sol, via the function _notPaused();

Note the other 2 puase mechanisms are: modifier whenNotPaused from openzeppelin Pausable.sol function _whenProtocolNotPaused()

It is confusing to have multiple mechanisms for the same goal.

Proof of Concept

MplRewards.sol function _notPaused() internal view { require(!paused, "REWARDS:CONTRACT_PAUSED"); }

Tools Used

editor

Recommended Mitigation Steps

Simplify the pause mechanisms

lucas-manuel commented 3 years ago

Won't address, not a bug