code-423n4 / 2021-04-maple-findings

0 stars 0 forks source link

Confirm/Delete a TODO comment on stake lockup period in StakeLocker.sol #40

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

0xRajeev

Vulnerability details

Impact

The below comment on the stake lockup period (L52 in StakeLocker.sol constructor) indicates that the default value has not been confirmed:

lockupPeriod = 180 days; // TODO: Confirm default

Proof of Concept

https://github.com/maple-labs/maple-core/blob/355141befa89c7623150a83b7d56a5f5820819e9/contracts/StakeLocker.sol#L52

Tools Used

Manual Analysis

Recommended Mitigation Steps

Confirm the correct default value and delete the TODO comment on stake lockup period.

lucas-manuel commented 3 years ago

We are aware of TODOs