code-423n4 / 2021-04-maple-findings

0 stars 0 forks source link

Unnecessary check for `uint256 >= 0` #79

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

a_delamo

Vulnerability details

Impact

Low

Proof of Concept

Here you have a gist: https://gist.github.com/alexon1234/a4eb109657e042dccca69dad836ece64

lucas-manuel commented 3 years ago

This is needed, so we will keep it.

Arachnid commented 3 years ago

@lucas-manuel Can you expand on this? A uint256 can't be less than zero.

lucas-manuel commented 3 years ago

Sorry I misread this issue, we have actually inadvertently addressed this here: https://github.com/maple-labs/maple-core/pull/365/files#diff-ee211eee306aee5a7e25b0edb3c74a678b3aac545578601c5d11bf36d5a7d429L449-R449