code-423n4 / 2021-04-maple-findings

0 stars 0 forks source link

Comment indicates that FundsWithdrawn event should be emitted only when _withdrawableDividend > 0 #96

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

paulius.eth

Vulnerability details

A comment says: "It emits a FundsWithdrawn event if the amount of withdrawn ether is greater than 0." However, actually, this event is always emitted (no check against 0).

Recommended Mitigation Steps

Either emit this event if _withdrawableDividend > 0 or remove the comment.

lucas-manuel commented 3 years ago

Informational, will address