zscole
commented
3 years ago This submission has been judged as non-critical since this has no impact on the security or functionality of the contract.
Open code423n4 opened 3 years ago
zscole
commented
3 years ago This submission has been judged as non-critical since this has no impact on the security or functionality of the contract.
Email address
mail@gpersoon.com
Handle
gpersoon
Eth address
gpersoon.eth
Vulnerability details
This is a minor suggestion.
RoleAware.sol contains functions for most of the constants. However the one exception is TOKEN_ADMIN.
Impact
The code is slightly longer than necessary.
Recommended mitigation steps
Remove the constant TOKEN_ADMIN, or provide a comment why it isn't used.