zscole
commented
3 years ago This submission has been judged as non-critical since this has no impact on the security or functionality of the contract.
Open code423n4 opened 3 years ago
zscole
commented
3 years ago This submission has been judged as non-critical since this has no impact on the security or functionality of the contract.
Email address
mail@gpersoon.com
Handle
gpersoon
Eth address
gpersoon.eth
Vulnerability details
This is a minor suggestion.
The function viewCumulativeYieldFP in HourlyBondSubscrptionLending.sol has a parameter named timestamp.
Impact
As there is also an inbuilt variable block.timestamp this could be confusing.
Recommended mitigation steps
Rename the parameter timestamp to a slightly different name.