Open code423n4 opened 3 years ago
mail@cmichel.io
@cmichelio
0x6823636c2462cfdcD8d33fE53fBCD0EdbE2752ad
The CrossDeposit, CrossTrade, CrossWithdraw, CrossBorrow, CrossOvercollateralizedBorrow events in MarginRouter are not indexed.
CrossDeposit
CrossTrade
CrossWithdraw
CrossBorrow
CrossOvercollateralizedBorrow
MarginRouter
Off-chain scripts cannot efficiently filter these events.
Add an index on important arguments like trader.
trader
Email address
mail@cmichel.io
Handle
@cmichelio
Eth address
0x6823636c2462cfdcD8d33fE53fBCD0EdbE2752ad
Vulnerability details
The
CrossDeposit,CrossTrade,CrossWithdraw,CrossBorrow,CrossOvercollateralizedBorrowevents inMarginRouterare not indexed.Impact
Off-chain scripts cannot efficiently filter these events.
Recommended mitigation steps
Add an index on important arguments like
trader.