code-423n4 / 2021-04-marginswap-findings

1 stars 0 forks source link

function crossWithdrawETH does not emit withdraw event #34

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Email address

pauliax6@gmail.com

Handle

paulius.eth

Eth address

0x523B5b2Cc58A818667C22c862930B141f85d49DD

Vulnerability details

contract MarginRouter, function crossWithdrawETH does not emit withdraw event: emit CrossWithdraw(msg.sender, WETH, withdrawAmount);

Impact

no impact on security.

Recommended mitigation steps

emit the expected event

zscole commented 3 years ago

Downgrading this from proposed severity of 1 (Low Risk) to 0 Non-critical as it has no effect on the performance of the system and presents no security risk.