code-423n4 / 2021-04-marginswap-findings

1 stars 0 forks source link

function initTranche should check that the share parameter is > 0 #35

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Impact

only admin can call this so highly unlikely to happen yet it would be better if code prevents that.

Recommended mitigation steps

require share to be greater than 0.

Tools used

Email address

pauliax6@gmail.com

Handle

paulius.eth

Eth address

0x523B5b2Cc58A818667C22c862930B141f85d49DD

Vulnerability details

function initTranche should check that the "share" parameter is > 0, otherwise, it may be possible to initialize the same tranche again.