code-423n4 / 2021-04-marginswap-findings

1 stars 0 forks source link

runtime > 1 hours error message discrepancy #36

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Email address

pauliax6@gmail.com

Handle

paulius.eth

Eth address

0x523B5b2Cc58A818667C22c862930B141f85d49DD

Vulnerability details

Here, the revert message says that the value needs to be at least 1 hour, however, the code allows value only above the 1 hour (> instead of >=): require(runtime > 1 hours, "Min runtime needs to be at least 1 hour");

Impact

no impact on security, just a discrepancy between the check and message.

Recommended mitigation steps

Replace > with >= or update the error message to reflect that.