code-423n4 / 2021-04-marginswap-findings

1 stars 0 forks source link

[INFO] All caps indicates that the value should be constant #42

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Email address

pauliax6@gmail.com

Handle

paulius.eth

Eth address

0x523B5b2Cc58A818667C22c862930B141f85d49DD

Vulnerability details

This is FYI, not a real issue as you have expressed your interest in minor improvement suggestions (not security or gas related):

All caps indicates that the value should be constant: uint256 public MAINTAINER_CUT_PERCENT = 5; However, it can be changed with function setMaintainerCutPercent. Then, this comment may become innacurate: // 5% of value borrowed Same with UPDATE_RATE_PERMIL, UPDATE_MAX_PEG_AMOUNT, UPDATE_MIN_PEG_AMOUNT.

Impact

Recommended mitigation steps