search

code-423n4 / 2021-04-marginswap-findings

1 stars 0 forks source link

[INFO] Useless overflow comments #45

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Email address

pauliax6@gmail.com

Handle

paulius.eth

Eth address

0x523B5b2Cc58A818667C22c862930B141f85d49DD

Vulnerability details

This is FYI, not a real issue as you have expressed your interest in minor improvement suggestions (not security or gas related):

I think this comment is useless when Solidity 0.8 is used (protection from overflow by default):

// no overflow because depositAmount >= extinguishableDebt uint256 addedHolding = depositAmount - extinguishableDebt;

there are more such comments, for example: /// won't overflow borrowAmount = inAmount - sellAmount;