code-423n4 / 2021-04-marginswap-findings

1 stars 0 forks source link

[INFO] Optimize the inheritance tree #50

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Email address

pauliax6@gmail.com

Handle

paulius.eth

Eth address

0x523B5b2Cc58A818667C22c862930B141f85d49DD

Vulnerability details

This is FYI, not a real issue as you have expressed your interest in minor improvement suggestions (not security or gas related):

Optimize the inheritance tree. For example: contract Lending is BaseLending, HourlyBondSubscriptionLending, BondLending, ...

abstract contract BondLending is BaseLending

abstract contract HourlyBondSubscriptionLending is BaseLending so Lending already inherits BaseLending from BondLending and HourlyBondSubscriptionLending.