Several TODO's are left in the code:
IsolatedMarginAccounts.sol: // TODO check if underflow?
IsolatedMarginAccounts.sol: // TODO TELL LENDING
IsolatedMarginLiquidation.sol: // TODO pay off / extinguish that loan
Lending.sol:// TODO activate bonds for lending
Lending.sol:// TODO disburse token if isolated bond issuer
MarginRouter.sol: // TODO minimum trade?
Impact
TODO usually mean something still have to be checked of done. This could lead to vulnerabilities if not verified.
Tools used
grep
Recommended mitigation steps
Check the TODO's and fix if necessary. Remove them afterwards
Email address
mail@gpersoon.com
Handle
gpersoon
Eth address
gpersoon.eth
Vulnerability details
This is a minor suggestion.
Several TODO's are left in the code: IsolatedMarginAccounts.sol: // TODO check if underflow? IsolatedMarginAccounts.sol: // TODO TELL LENDING IsolatedMarginLiquidation.sol: // TODO pay off / extinguish that loan Lending.sol:// TODO activate bonds for lending Lending.sol:// TODO disburse token if isolated bond issuer MarginRouter.sol: // TODO minimum trade?
Impact
TODO usually mean something still have to be checked of done. This could lead to vulnerabilities if not verified.
Tools used
grep
Recommended mitigation steps
Check the TODO's and fix if necessary. Remove them afterwards