search

code-423n4 / 2021-04-meebits-findings

0 stars 0 forks source link

Missing event in critical pauseMarket() function #38

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

0xRajeev

Vulnerability details

Impact

Pausing/unpausing of the market by the deployer is a significant event for market participants because it prevents/allows trades. However, this is missing an event for off-chain monitoring of the critical on-chain change.

Proof of Concept

https://github.com/code-423n4/2021-04-redacted/blob/2ec4ce8e98374be2048126485ad8ddacc2d36d2f/Beebots.sol#L230-L233

https://github.com/code-423n4/2021-04-redacted/blob/2ec4ce8e98374be2048126485ad8ddacc2d36d2f/Beebots.sol#L619-L620

Tools Used

Manual Analysis

Recommended Mitigation Steps

Add an event for marketPaused change and emit at the end of pauseMarket() function.