code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Missing event for critical init() function in DAO.sol #172

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

0xRajeev

Vulnerability details

Impact

The init() function initialises critical protocol parameters for this contract but is missing an event emission for off-chain monitoring tools to monitor this on-chain change.

Proof of Concept

https://github.com/code-423n4/2021-04-vader/blob/3041f20c920821b89d01f652867d5207d18c8703/vader-protocol/contracts/DAO.sol#L46-L53

Tools Used

Manual Analysis

Recommended Mitigation Steps

Add an init event and emit that at the end of init() function.

dmvt commented 3 years ago

duplicate of #108