Open code423n4 opened 3 years ago
jvaqa
Gas Optimization: Vader.sol Unnecessary Conditional
You can remove this conditional entirely.
In Vader.sol, change this:
if(emitting){ emitting = false; } else { emitting = true; }
To this:
emitting = !emitting;
https://github.com/vetherasset/vaderprotocol-contracts/commit/b98b6358f1d8b7730d3fe767e01d49ca63d830e9#diff-f5afe9240d284bf89e33b79c68c1ab21a6c18323c11d480d25144c18b8a9373a
0xBrian
commented
3 years ago
Handle
jvaqa
Vulnerability details
Impact
Gas Optimization: Vader.sol Unnecessary Conditional
You can remove this conditional entirely.
Recommended Mitigation Steps
In Vader.sol, change this:
if(emitting){ emitting = false; } else { emitting = true; }
To this:
emitting = !emitting;