search

code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Gas Optimization: Vader.sol Unnecessary Conditional #2 #198

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

jvaqa

Vulnerability details

Gas Optimization: Vader.sol Unnecessary Conditional

You can remove this conditional entirely.

Recommended Mitigation Steps

In Vader.sol, change this:

if(minting){
    minting = false;
} else {
    minting = true;
}

To this:

minting = !minting;

0xBrian commented 3 years ago

https://github.com/vetherasset/vaderprotocol-contracts/commit/b98b6358f1d8b7730d3fe767e01d49ca63d830e9#diff-f5afe9240d284bf89e33b79c68c1ab21a6c18323c11d480d25144c18b8a9373a

dmvt commented 3 years ago

duplicate of #197