search

code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Gas Optimization: DAO.sol Unnecessary Multiple Return Statements #200

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

jvaqa

Vulnerability details

Impact

Gas Optimization: DAO.sol Unnecessary Multiple Return Statements

Recommended Mitigation Steps

In DAO.sol, replace this:

if(votes > consensus){ return true; } else { return false; }

With this:

return (votes > consensus)

0xBrian commented 3 years ago

https://github.com/vetherasset/vaderprotocol-contracts/commit/6bbdab961f83d0479c0417dbf522567fa184bee7