code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Missing access restriction on `lockUnits/unlockUnits` #208

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

@cmichelio

Vulnerability details

Vulnerability Details

The Pool.lockUnits allows anyone to steal pool tokens from a member and assign them to msg.sender.

Impact

Anyone can steal pool tokens from any other user.

Recommended Mitigation Steps

Add access control and require that msg.sender is the router or another authorized party.

strictly-scarce commented 3 years ago

Valid, although this is part of the partially-complete lending code.