Closed code423n4 closed 3 years ago
@cmichelio
The latest Vether contract does not emit the Approval event on transferFrom. It should if the approval changed.
Approval
transferFrom
Off-chain scripts cannot keep track of the correct approvals and might suggest wrong approvals for the frontend.
Emit the Approval event when the approval is decreased in transferFrom.
Vether not applicable
duplicate of #250
Handle
@cmichelio
Vulnerability details
Vulnerability Details
The latest Vether contract does not emit the
Approval
event ontransferFrom
. It should if the approval changed.Impact
Off-chain scripts cannot keep track of the correct approvals and might suggest wrong approvals for the frontend.
Recommended Mitigation Steps
Emit the Approval event when the approval is decreased in
transferFrom
.