search

code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Missing Approval event in Vether #225

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

@cmichelio

Vulnerability details

Vulnerability Details

The latest Vether contract does not emit the Approval event on transferFrom. It should if the approval changed.

Impact

Off-chain scripts cannot keep track of the correct approvals and might suggest wrong approvals for the frontend.

Recommended Mitigation Steps

Emit the Approval event when the approval is decreased in transferFrom.

strictly-scarce commented 3 years ago

Vether not applicable

dmvt commented 3 years ago

duplicate of #250