search

code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

Canceled proposals can still be executed #228

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

@cmichelio

Vulnerability details

Vulnerability Details

Proposals that passed the threshold ("finalized") can be cancelled by a minority again using the cancelProposal functions. It only sets mapPID_votes to zero but mapPID_timeStart and mapPID_finalising stay the same and pass the checks in finaliseProposal which queues them for execution.

Impact

Proposals cannot be cancelled.

Recommended Mitigation Steps

Set a cancel flag and check for it in finaliseProposal and in execution.

strictly-scarce commented 3 years ago

Valid